Rule | Applicable to Android Application Development? | Comments |
|---|
| IDS00-J. Sanitize untrusted data passed across a trust boundary | Applicable in principle | The rule uses MS SQL Server as an example to show a database connection. However, on Android, DatabaseHelper from SQLite is used for a database connection. Because Android apps may receive untrusted data via network connections, the rule is applicable. |
| IDS01-J. Normalize strings before validating them | Applicable in principle | Android apps can receive string data from the outside and normalize it. |
| IDS02-J. Canonicalize path names before validating themApplicable in principle | The rule is applicable in principle. Please refer to the Android specific instance of this rule: DRD08-J. Always canonicalize a URL received by a content provider. |
| IDS04-J. Safely extract files from ZipInputStream | Applicable in principle | Although not directly a violation of this rule, the Android Master Key vulnerability (insecure use of ZipEntry) is related to this rule. Another attack vector found by a Chinese researcher is also related to this rule. |
| IDS07-J. Do not pass untrusted, unsanitized data to the Runtime.exec() methodApplicable in principle | Runtime.exec() can be called from Android apps to execute operating system commands. |
| IDS09-J. Do not use locale-dependent methods on locale-dependent data without specifying the appropriate localeApplicable in principle | A developer can specify locale on Android using java.util.Locale. |
| EXP01-J. Never dereference null pointers | Applicable in principle | Android applications are more sensitive to NullPointerException due to the constraint of the limited mobile device memory. Static members or members of an Activity may become null when memory runs out. |
| EXP06-J. Do not use side-effecting expressions in assertionsApplicable in principle | The assert statement is supported on the Dalvik VM but is ignored under the default configuration. Assertions may be enabled by setting the system property "debug.assert" via: adb shell setprop debug.assert 1 or by sending the command line argument "--enable-assert" to the Dalvik VM. |
| NUM00-J. Detect or prevent integer overflowApplicable in principle | Mezzofanti for Android contained an integer overflow which prevented the use of a big SD card. Mezzofanti contained an expression: (int) StatFs.getAvailableBlocks() * (int) StatFs.getBlockSize()
to calculate the available memory in a SD card, which could result in a negative value when the available memory is bigger than Integer.MAX_VALUE. Note these methods are deprecated in API level 18 and replaced by getAvailableBlocksLong() and getBlockSizeLong(). |
| NUM04-J. Do not use floating-point numbers if precise computation is requiredApplicable in principle | The use of floating-point is not recommended for performance reasons on Android. |
| NUM06-J. Use the strictfp modifier for floating-point calculation consistency across platforms | Applicable in principle | |
| NUM11-J. Do not compare or inspect the string representation of floating-point values | Applicable in principle | Comparing or inspecting the string representation of floating-point values may have unexpected results on Android. |
| OBJ03-J. Do not mix generic with nongeneric raw types in new code | [Applicable] | <Could not find a page with this title.> |
| MET01-J. Never use assertions to validate method arguments | Applicable in principle | The assert statement is supported on the Dalvik VM but is ignored under the default configuration. Assertions may be enabled by setting the system property "debug.assert" via: adb shell setprop debug.assert 1 or by sending the command line argument "--enable-assert" to the Dalvik VM. |
| MET02-J. Do not use deprecated or obsolete classes or methods | Applicable in principle | The Android SDK also has deprecated or obsolete APIs. Also, there may exist incompatible APIs depending on the SDK version. Therefore, it is recommended that developers refer to the "Android API Difference report" and consider replacing the deprecated APIs. |
| MET03-J. Methods that perform a security check must be declared private or finalApplicable in principle | On Android, System.getSecurityManager() is not used and the use of a Security Manager is not exercised. However, an Android developer can implement security-sensitive methods so the principle may be applicable on Android. |
| ERR09-J. Do not allow untrusted code to terminate the JVM | Applicable in principle | On Android, System.exit() should not be used because it will terminate the virtual machine abruptly, ignoring the activity lifecycle which may prevent proper garbage collection. |
| LCK00-J. Use private final lock objects to synchronize classes that may interact with untrusted code | Applicable in principle | |
| LCK05-J. Synchronize access to static fields that can be modified by untrusted codeApplicable in principle | |
| LCK11-J. Avoid client-side locking when using classes that do not commit to their locking strategyApplicable in principle | |
| THI00-J. Do not invoke Thread.run()Applicable in principle | Android provides a couple of solutions for threading. The Android Developers Blog's article "Painless threading" discusses those solutions. |
| THI02-J. Notify all waiting threads rather than a single thread | Applicable in principle | |
| THI03-J. Always invoke wait() and await() methods inside a loop | Applicable in principle | |
| THI04-J. Ensure that threads performing blocking operations can be terminatedApplicable in principle | |
| THI05-J. Do not use Thread.stop() to terminate threadsApplicable in principle | On Android, Thread.stop() was deprecated in API level 1. |
| TPS00-J. Use thread pools to enable graceful degradation of service during traffic burstsApplicable in principle | |
| TPS01-J. Do not execute interdependent tasks in a bounded thread pool | Applicable in principle | |
| TPS02-J. Ensure that tasks submitted to a thread pool are interruptibleApplicable in principle | |
| TPS03-J. Ensure that tasks executing in a thread pool do not fail silentlyApplicable in principle | |
| TPS04-J. Ensure ThreadLocal variables are reinitialized when using thread poolsApplicable in principle | |
| TSM00-J. Do not override thread-safe methods with methods that are not thread-safeApplicable in principle | |
| TSM01-J. Do not let the this reference escape during object construction | Applicable in principle | |
| TSM02-J. Do not use background threads during class initialization | Applicable in principle | |
| FIO00-J. Do not operate on files in shared directories | Applicable in principle | On Android, the SD card ( / sdcard or /mnt/ sdcard ) is shared among multiple applications, thus sensitive files should not be stored on the SD card. |
| FIO01-J. Create files with appropriate access permissions | Applicable in principle | Creating files with weak permissions may allow malicious applications to access the files. |
| FIO04-J. Release resources when they are no longer needed | Applicable in principle | The compliant solution (Java SE 7: try-with-resources) is not yet supported at API level 18 (Android 4.3). |
| FIO06-J. Do not create multiple buffered wrappers on a single InputStreamApplicable in principle | |
| FIO08-J. Use an int to capture the return value of methods that read a character or byte | [Applicable] | <This page was deleted. We can ask for it to be undeleted. Please advise.> |
| FIO11-J. Do not attempt to read raw binary data as character data | [Applicable] | <The link on the left does not work. Please advise.> |
| FIO13-J. Do not log sensitive information outside a trust boundary | Applicable in principle | DRD04-J. Do not log sensitive information is an Android specific instance of this rule. |
| FIO14-J. Perform proper cleanup at program termination | Applicable in principle | Although most of the code examples are not applicable to the Android platform, the principle is applicable to Android. There are a number of ways to terminate a process on Android: android.app.Activity.finish(), and the related finish... methods, android.app.Activity.moveTaskToBack(boolean flag), android.os.Process.killProcess(int pid), System.exit(). |
| FIO15-J. Do not operate on untrusted file linksApplicable in principle | |
| SEC01-J. Do not allow tainted variables in privileged blocksApplicable in principle | The code examples using the java.security package are not applicable to Android but the principle of the rule is applicable to Android apps. |
| SEC02-J. Do not base security checks on untrusted sourcesApplicable in principle | The code examples using the java.security package are not applicable to Android but the principle of the rule is applicable to Android apps. |
| SEC03-J. Do not load trusted classes after allowing untrusted code to load arbitrary classes | Applicable in principle | On Android, the use of DexClassLoader or PathClassLoader requires caution. |
| SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields | Applicable in principle | Reflection can be used on Android so the rule is applicable. Also the use of reflection may allow a developer to access private Android APIs and so requires caution. |
| JNI 03-J. Do not use direct pointers to Java objects in JNI codeApplicable in principle | Applicable to API versions 14 and above, with NDK versions 7 and above. |
| ENV02-J. Do not trust the values of environment variablesApplicable in principle | On Android, the environment variable user.name is not used and is left blank. However, environment variables exist and are used on Android so the rule is applicable. |
| ENV04-J. Do not disable bytecode verificationApplicable in principle | Under the default settings, bytecode verification is enabled on the Dalvik VM. To change the settings use the adb shell to set the appropriate system property, for example: adb shell setprop dalvik.vm.dexopt-flags v=a or pass -Xverify:all as an argument to the Dalvik VM. |
| MSC03-J. Never hard code sensitive information | Applicable in principle | Hard coded information can be easily obtained on Android by using the apktool to decompile an application or by using dex2jar to convert a dex file to a jar file. |