Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: touched up formatting

pthread_cond_wait() and pthread_cond_timedwait() take a condition variable and locked mutex as arguments. These functions unlock the mutex until the condition variable is signaled and then re-lock the mutex before returning. While a thread is waiting on a particular condition variable and mutex, other threads may only wait on the same condition variable if they also pass the same mutex as an argument. This requirement is noted in the Open Group Base Specifications Issue 6:

…as ...as long as at least one thread is blocked on the condition variable. During this time, the effect of an attempt by any thread to wait on that condition variable using a different mutex is undefined.

It also specifies that pthread_cond_wait() “may” fail if:

Wiki Markup
\[EINVAL\]
The value specified by cond or mutex is invalid.
\[EPERM\]
The mutex was not owned by the current thread at the time of the call.

...

In this noncompliant code example, mutex1 protects count1 and mutex2 protects count2. A race condition exists between the waiter1 and waiter2 threads since they use the same condition variable with different mutexes. If both threads attempt to call pthread_cond_wait() at the same time, one thread will succeed and the other thread will invoke undefined behavior.

Code Block
bgColor#FFcccc
#include <stdio.h>
#include <string.h>
#include <pthread.h>
#include <assert.h>
#include <unistd.h>
#include <errno.h>

pthread_mutex_t mutex1;
pthread_mutex_t mutex2;
pthread_mutexattr_t attr;
pthread_cond_t cv;

void * waiter1();
void * waiter2();
void * signaler();

int count1 = 0, count2 = 0;
#define COUNT_LIMIT 5

int main()
 {
  int ret;
  pthread_t thread1, thread2, thread3;

  if ( (ret = pthread_mutexattr_init( &attr )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_mutexattr_settype( &attr, PTHREAD_MUTEX_ERRORCHECK )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_mutex_init( &mutex1, &attr )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_mutex_init( &mutex2, &attr )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_cond_init( &cv, NULL )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_create( &thread1, NULL, &waiter1, NULL )) ) {
    /* handle error */
  }

  if ( (ret = pthread_create( &thread2, NULL, &waiter2, NULL)) ) {
    /* handle error */
  }

  if ( (ret = pthread_create( &thread3, NULL, &signaler, NULL)) ) {
    /* handle error */
  }

  if ( (ret = pthread_join( thread1, NULL )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_join( thread2, NULL )) != 0 ) {
    /* handle error */
  }

  if ( (ret = pthread_join( thread3, NULL )) != 0 ) {
    /* handle error */
  }

  return 0;
}


void * waiter1() {
  int ret;
  while ( count1 < COUNT_LIMIT ) {
    if ( (ret = pthread_mutex_lock(&mutex1)) != 0 ) {
      /* handle error */
    }

    if ( (ret = pthread_cond_wait(&cv, &mutex1)) != 0 ) {
      /* handle error */
    }

    printf("count1 = %d\n", ++count1);

    if ( (ret = pthread_mutex_unlock(&mutex1)) != 0 ) {
      /* handle error */
    }
  }

  return NULL;
}

void * waiter2() {
  int ret;
  while ( count2 < COUNT_LIMIT ) {
    if ( (ret = pthread_mutex_lock(&mutex2)) != 0 ) {
      /* handle error */
    }

    if ( (ret = pthread_cond_wait(&cv, &mutex2)) != 0 ) {
      /* handle error */
    }

    printf("count2 = %d\n", ++count2);

    if ( (ret = pthread_mutex_unlock(&mutex2)) != 0 ) {
      /* handle error */
    }
  }

  return NULL;
}

void * signaler() {
  int ret;
  while ( (count1 < COUNT_LIMIT) || (count2 < COUNT_LIMIT) ) {
    sleep(1);
    printf("signaling\n");
    if ( (ret = pthread_cond_signal(&cv)) != 0 ) {
      /* handle error */
    }
  }

  return NULL;
}

Implementation Details: Linux

When the system is built on the following platform:

Red Hat Enterprise Linux Client release 5.5 (Tikanga)
kernel 2.6.18
gcc 4.3.5 with the --D_GNU_SOURCE flag

In this configuration, the above code works as expected. Waiter1 and waiter2 increment the variable once they are signaled and the correct mutex is acquired after pthread_cond_wait returns in each thread.

The man page for pthread_cond_wait on this configuration says that it “may” fail with a return value of EINVAL if “different mutexes were supplied for concurrent pthread_cond_timedwait() or pthread_cond_wait() operations on the same condition variable.” This does not happen however.

Implementation Details: OS X

When the system is built on the following platform:

OS X 10.6.4 (Snow Leopard)
gcc 4.2.1

In this configuration, pthread_cond_wait() returns EINVAL if it is called when another thread is waiting on the condition variable with a different mutex. This is arguably better since it forces the coder to fix the problem instead of allowing reliance on undefined behavior.

The man page for pthread_cond_wait()}] simply says that {{EINVAL will be returned if “The value specified by cond or the value specified by mutex is invalid.” but it doesn’t say what invalid means.

...

Code Block
bgColor#ccccff
pthread_mutex_t mutex1; /* initialized as PTHREAD_MUTEX_ERRORCHECK */
pthread_cond_t cv;
int count1 = 0, count2 = 0;

void * waiter1() {
  int ret;
  while ( count1 < COUNT_LIMIT ) {
    if ( (ret = pthread_mutex_lock(&mutex1)) != 0 ) {
      /* handle error */
    }

    if ( (ret = pthread_cond_wait(&cv, &mutex1)) != 0 ) {
      /* handle error */
    }

    printf("count1 = %d\n", ++count1);

    if ( (ret = pthread_mutex_unlock(&mutex1)) != 0 ) {
      /* handle error */
    }
  }

  return NULL;
}

void * waiter2() {
  int ret;
  while ( count2 < COUNT_LIMIT ) {
    if ( (ret = pthread_mutex_lock(&mutex1)) != 0 ) {
      /* handle error */
    }

    if ( (ret = pthread_cond_wait(&cv, &mutex1)) != 0 ) {
      /* handle error */
    }

    printf("count2 = %d\n", ++count2);

    if ( (ret = pthread_mutex_unlock(&mutex1)) != 0 ) {
      /* handle error */
    }
  }

  return NULL;
}

...