SEI CERT C Coding Standard

Space shortcuts

Page tree

Versions Compared

Old Version 23

changes.mady.by.user Alex Volkovitsky

Saved on

compared with

New Version 24

changes.mady.by.user Justin Pincar

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Code Block
bgColor#ffcccc
void do_stuff(void) {
   FILE *logfile = fopen("log", "a");

   /* Check for errors, write logs pertaining to 
    * do_stuff(), etc. */
}

int main(void) {
   FILE *logfile = fopen("log", "a");    /* Check for errors, write logs pertaining to
    * main(), etc. */
   FILE *logfile = fopen("log", "a");    

   do_stuff();
   /* ... */
}

However, the file log is opened twice simultaneously. The result is implementation-defined and potentially dangerous.

...

Code Block
bgColor#ccccff
void do_stuff(FILE *logfile) {
  /* Check for errors, write logs pertaining to 
   * do_stuff, etc. */
}

int main(void) {
  FILE *logfile = fopen("log", "a");

  /* Check for errors, write logs pertaining to main, etc. */

  do_stuff(logfile);

  /* ... */
}

...