Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: compliance with FIO00-PL

...

Code Block
bgColor#ffcccc
langperl
my $source;
open(SOURCEmy $SOURCE, "<", $source);
@lines = (<SOURCE><$SOURCE>);
close(SOURCE$SOURCE);

It makes sure the variable containing the file name is properly defined, but it does nothing else to catch errors. Consequently, any error, such as the file not existing, being unreadable, or containing too much data to read into memory, will cause the program to abort.

...

Code Block
bgColor#ccccff
langperl
my $source;
open(SOURCEmy $SOURCE, "<", $source) or croak "error opening $source: $!";
@lines = (<SOURCE><$SOURCE>);
close(SOURCE$SOURCE) or croak "error closing $source: $!";

...

Code Block
bgColor#ccccff
langperl
use autodie;

my $source;
open(SOURCEmy $SOURCE, "<", $source);
@lines = (<SOURCE><$SOURCE>);
close(SOURCE$SOURCE);

EXP32:EX2: Functions that send data to standard output or standard error need not have their return values checked. This includes print and printf, but only if their file handle argument is not supplied or is explicitly set to *STDOUT or *STDERR. If they send their output to any other file handle, their return value must be checked.

...

[Conway 2005]"Error Checking," p. 208
[CPAN]autodie
[Open Group 2008]open()