
...
On Windows platforms, the CryptGenRandom BCryptGenRandom()
function can be used to generate cryptographically strong random numbers. The exact details of the implementation are unknown, including, for example, what source of entropy CryptGenRandom()
uses. The Microsoft Developer Network CryptGenRandomBCryptGenRandom()
reference [MSDN] states:
The default random number provider implements an algorithm for generating random numbers that complies with the NIST SP800-90 standard, specifically the CTR_DRBG portion of that standardIf an application has access to a good random source, it can fill the
pbBuffer
buffer with some random data before callingCryptGenRandom()
. The CSP [cryptographic service provider] then uses this data to further randomize its internal seed. It is acceptable to omit the step of initializing thepbBuffer
buffer before callingCryptGenRandom()
.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <Windows.h> #include <wincrypt<bcrypt.h> #include <stdio.h> #pragma comment(lib, "Bcrypt") void func(void) { HCRYPTPROV provBCRYPT_ALG_HANDLE Prov; int Buffer; if (CryptAcquireContext!BCRYPT_SUCCESS( BCryptOpenAlgorithmProvider(&provProv, NULLBCRYPT_RNG_ALGORITHM, NULL, PROV_RSA_FULLNULL, 0))) { long/* inthandle li = 0;error */ } if (CryptGenRandom(prov!BCRYPT_SUCCESS(BCryptGenRandom(Prov, sizeof(liPUCHAR), (BYTE *)&li)) { Buffer), printf("Random number: %ld\n", li); } else { /* Handle error */ } if (!CryptReleaseContext(provsizeof(Buffer), 0))) { /* Handlehandle error */ } } else {printf("Random number: %d\n", Buffer); /* Handle error */ }BCryptCloseAlgorithmProvider(Prov, 0); } |
Risk Assessment
The use of the rand()
function can result in predictable random numbers.
Rule | Severity | Likelihood | Detectable | Remediation CostRepairable | Priority | Level |
---|---|---|---|---|---|---|
MSC30-C | Medium | Unlikely | Yes | LowNo | P6P4 | L2L3 |
Automated Detection
Tool | Version | Checker | Description | |||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Astrée |
| stdlib-use-rand | Fully checked | |||||||||||||||
Axivion Bauhaus Suite |
| Supported, but no explicit checkerCertC-MSC30 | ||||||||||||||||
Clang |
| cert-msc30-c | Checked by clang-tidy | |||||||||||||||
CodeSonar |
| BADFUNC.RANDOM.RAND | Use of rand | |||||||||||||||
Compass/ROSE | ||||||||||||||||||
Coverity |
| DONTCALL | Implemented - weak support | |||||||||||||||
Cppcheck Premium |
| premium-cert-msc30-c | ||||||||||||||||
| CC2.MSC30 | Fully implemented | ||||||||||||||||
Helix QAC |
| C5022 C++5029 | ||||||||||||||||
Klocwork |
| CERT.MSC.STD_RAND_CALL | ||||||||||||||||
LDRA tool suite |
| 44 S | Enhanced enforcement | |||||||||||||||
Parasoft C/C++test |
| CERT_C-MSC30-a | Do not use the rand() function for generating pseudorandom numbers | |||||||||||||||
PC-lint Plus |
| 586 | Fully supported | |||||||||||||||
Polyspace Bug Finder |
| Vulnerable CERT C: Rule MSC30-C | Checks for vulnerable pseudo-random number generator | Using a cryptographically weak pseudo-random number generator | PRQA QA-C | |||||||||||||
Include Page | PRQA QA-C_v | PRQA QA-C_v | (rule fully covered) | |||||||||||||||
RuleChecker |
| stdlib-use-rand | Fully checked | |||||||||||||||
Security Reviewer - Static Reviewer |
| RTOS_07 | 5022Fully implemented |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
...
Key here for mapping notes
CWE-327 and MSC30-C
- CWE-327 forbids “broken or risky cryptographic algorithms” but does not specify what constitutes such an algo.
- Per CERT judgement, rand() qualifies, so:
- CWE-327 = Union( MSC30-C, list) where list =
- Invocation of broken/risky crypto algorithms besides rand()
CWE-338 and MSC30-C
CWE-338 = Union( MSC30-C, list) where list =
- Use of a weak PRNG besides standard C rand().
CWE-330 and MSC30-C
Independent( MSC30-C, MSC32-C, CON33-C)
...
MSC30-C, MSC32-C and CON33-C are independent, they have no intersections. They each specify distinct errors regarding PRNGs.
CWE-676 and MSC30-C
- Independent( ENV33-C, CON33-C, STR31-C, EXP33-C, MSC30-C, ERR34-C)
- MSC30-C implies that rand() is dangerous.
- CWE-676 = Union( MSC30-C, list) where list =
- Invocation of other dangerous functions, besides rand().
Bibliography
[MSDN] | " CryptGenRandom |
[OpenBSD] | arc4random() |
...