...
Note the comment warning programmers that the macro is unsafe. The macro can also be renamed ABS_UNSAFE() to make it clear that the macro is unsafe. This compliant solution, like all the compliant solutions for this rule, has undefined behavior (see undefined behavior 36) if the argument to ABS() is equal to the minimum (most negative) value for the signed integer type. (See INT32-C. Ensure that operations on signed integers do not result in overflow for more information.)
...
This compliant solution follows the guidance of PRE00-C. Prefer inline or static functions to function-like macros by defining an inline function iabs() to replace the ABS() macro. Unlike the ABS() macro, which operates on operands of any type, the iabs() function will truncate arguments of types wider than int whose value is not in range of the latter type.
...
According to the C Standard, 6.5.12.1, paragraph 3 [ISO/IEC 9899:20112024]:
The controlling expression of a generic selection is not evaluated. If a generic selection has a generic association with a type name that is compatible with the type of the controlling expression, then the result expression of the generic selection is the expression in that generic association. Otherwise, the result expression of the generic selection is the expression in the
defaultgeneric association. None of the expressions from any other generic association of the generic selection is evaluated.
Because the expression is not evaluated as part of the generic selection, the use of a macro in this solution is guaranteed to evaluate the macro parameter v only once.
...
Invoking an unsafe macro with an argument that has side effects may cause those side effects to occur more than once. This practice can lead to unexpected program behavior.
Rule | Severity | Likelihood | Detectable | RepairableRemediation Cost | Priority | Level |
|---|---|---|---|---|---|---|
PRE31-C | Low | Unlikely | No | LowYes | P3P2 | L3 |
Automated Detection
Tool | Version | Checker | Description | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Astrée |
| expanded-side-effect-multiplied | Partially checked | ||||||||||||||||
| Axivion Bauhaus Suite |
| CertC-PRE31 | Fully implemented | ||||||||||||||||
| CodeSonar |
| LANG.PREPROC.FUNCMACRO | Function-Like Macro | ||||||||||||||||
| ASSERT_SIDE_EFFECTS | Partially implemented Can detect the specific instance where assertion contains an operation/function call that may have a side effect | |||||||||||||||||
| Cppcheck Premium |
| premium-cert-pre31-c | |||||||||||||||||
| ECLAIR |
| CC2.EXP31 CC2.PRE31 | Fully implemented | ||||||||||||||||
| Helix QAC |
| C3462, C3463, C3464,C3465,C3466,C3467 C++3225, C++3226, C++3227, C++3228, C++3229 | Fully implemented | ||||||||||||||||
| Klocwork |
| PORTING.VAR.EFFECTS | Fully implemented | ||||||||||||||||
| LDRA tool suite |
| 9 S, 562 S, 572 S, 35 D, 1 Q | Fully implemented | ||||||||||||||||
| Parasoft C/C++test |
| CERT_C-PRE31-aCERT_C-PRE31-b | A full expression containing an increment (++) or decrement (--) operator should have no other potential side effectsAssertions should not contain assignments, increment, or decrement operators | ||||||||||||||||
| PC-lint Plus |
| 666, 2666 | Fully supported | ||||||||||||||||
| Polyspace Bug Finder |
| CERT C: Rule PRE31-C | Checks for side effect in arguments to unsafe macro (rule partially covered) | PRQA QA-C||||||||||||||||
| RuleChecker |
| PRQA QA-C_v | PRQA QA-C_v | 3462, 3463, 3464, 3465, 3466, 3467 | Fully implemented | PRQA QA-C++ | |||||||||||||
| Include Page | cplusplus:PRQA QA-C++_V | cplusplus:PRQA QA-C++_V | 3225, 3226, 3227, 3228, 3229
| expanded-side-effect-multiplied | Partially checked | ||||||||||||||
| Security Reviewer - Static Reviewer |
| RTOS_28 | Fully implemented |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
Key here (explains table format and definitions)
...
| [Dewhurst 2002] | Gotcha #28, "Side Effects in Assertions" |
| [ISO/IEC 9899:20112024] | Subclause 6.5.12.1, "Generic Selection" |
| [Plum 1985] | Rule 1-11 |
...