Page History

If either of the C Standard fgets() or fgetws() functions fail, the contents of the array being written is indeterminate. (See undefined behavior 175.)  It is necessary to reset the string to a known value to avoid errors on subsequent string manipulation functions.

Noncompliant Code Example

In this noncompliant code

According to C99 \[[ISO/IEC 9899-1999|AA. C References#ISO/IEC 9899-1999]\], if the {{fgets()}} function fails, the contents of the array it was writing to are undefined. As a result it is necessary to reset the string to a known value to avoid possible errors on subsequent string manipulation functions.

Non-Compliant Code Example

In this example, an error flag is set upon if fgets() failure fails. However, buf is not reset , and will have unknown contents.has indeterminate contents:

#include <stdio.h>
 
enum { BUFFERSIZEBUFFER_SIZE = 1024 };
void func(FILE *file) {
  char buf[BUFFERSIZEBUFFER_SIZE];
FILE *file;
/* Initialize file */

if (fgets(buf, sizeof(buf), file) == NULL) {
    /* setSet error flag and continue */
}
printf("Read in: %s\n", buf);
 }
}

Compliant Solution

In this compliant solution, buf is set to an empty string if fgets() fails. The equivalent solution for fgetws() would set buf to an empty wide string.

#include <stdio.h>
 
enum { BUFFERSIZEBUFFER_SIZE = 1024 };

char buf[BUFFERSIZE];
void func(FILE *file;) {
/* Initialize file */char buf[BUFFER_SIZE];

  if (fgets(buf, sizeof(buf), file) == NULL) {
    /* setSet error flag and continue */
    *buf = '\0';
}
printf("Read in: %s\n", buf);
  }
}

Exceptions

FIO40-C-EX1: If the string goes out of scope immediately following the call to fgets() or fgetws() or is not referenced in the case of a failure, it need not be reset.

Risk Assessment

Making invalid assumptions about the contents of the an array set modified by fgets on failure could lead to undefined behavior, possibly resulting in () or fgetws() can result in undefined behavior 175 and abnormal program termination.

Automated Detection

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

\[[ISO/IEC 9899-1999|AA. C References#ISO/IEC 9899-1999]\] Section 7.19.7.2, "The {{fgets}} function"

...

FIO39-C. Do not read in from a stream directly following output to that stream      09. Input Output (FIO)       FIO41-C. Do not call getc() or putc() with stream arguments that have side effectsImage Added Image Added Image Added