Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: REM Cost Reform

The C Standard, 7.23.9.3 paragraph 2 [ISO/IEC 9899:2024], defines the following behavior for fsetpos():

The fsetpos function sets the mbstate_t object (if any) and file position indicator for the stream pointed to by stream according to the value of the object pointed to by pos, which shall be a value obtained from an earlier

Undefined behavior ;

...

successful call to the fgetpos function on a stream associated with the same file.

...

Invoking the fsetpos() function with any other values for pos is undefined behavior 181.

Noncompliant

...

Code Example

This noncompliant code example attempts to read three values from a file and then set the file position pointer back to the beginning of the file:

Code Block
bgColor#FFCCCC
langc
#include <stdio.h>
#include <string.h>
 
int add3opener(int x, int y,FILE *file) {
  int z)
{
&nbsp;&nbsp; return x+y+z;
}

void add2to3()
{
int (*function_pointer) (int, int) ;
function_pointer = &add3;
&nbsp;&nbsp;&nbsp; i = function_pointer(2,3);
&nbsp;&nbsp;&nbsp; printf(" ans = %d \n",i);
}

Compliant Solution

Code Block
bgColor#ccccff

int main(int argc, char \*argv\[\])
{
  FILE \*info = fopen( "widget.txt", "r");
  fpos_t&nbsp; pos;
  int a,b,c;
  if(info == NULL)
  rc;
  fpos_t offset;

  memset(&offset, 0, sizeof(offset));

  if (file == NULL) { 
    return -1;
  }

  /* Read in data from file */

  rc = fsetpos(file, &offset);
  if (rc != 0 ) {
      perror("Could not open file")return rc;
  }

     return 0;
  }
  if(fgetpos(info, &pos)\!=0)
 }

Only the return value of an fgetpos() call is a valid argument to fsetpos(); passing a value of type fpos_t that was created in any other way is undefined behavior 181.

Compliant Solution

In this compliant solution, the initial file position indicator is stored by first calling fgetpos(), which is used to restore the state to the beginning of the file in the later call to fsetpos():

Code Block
bgColor#CCCCFF
langc
#include <stdio.h>
#include <string.h>
 
int opener(FILE *file) {
  int  perror("fgetpos failed");rc;
  fpos_t offset;

  if  fclose(info);(file == NULL) {
    return return 0-1;
   }
 if(fscanf(info,"%i %i %i", &a, &b, &c)\!=3)
 {
   fprintf(stderr, "Expected but did not find three integers \n");
   fclose(info);
   return 0;
 }
 else
 {
   printf("abc is %i%i%i\n",a,b,c);
 }

if(fsetpos(info, &pos)\!=0)
{
  perror("fsetpos failed");
  fclose(info);
  rc = fgetpos(file, &offset);
  if (rc != 0 ) {
    return rc;
  }

  /* Read in data from file */

  rc = fsetpos(file, &offset);
  if (rc != 0 ) {
    return rc;
  }

  return 0;
}

if(fscanf(info,"%i %i %i", &a, &b, &c)\!=3)
{
  fprintf(stderr, "Expected but did not find %i %i %i \n");
}
else
{
  printf("abc is %i%i%i \n",a,b,c);
}

fclose(info);
return 0;
}

Risk Assessment

Misuse of the fsetpos() function can position a file position indicator to an unintended location in the file.

Rule

Severity

Likelihood

Detectable

Repairable

Priority

Level

FIO44-C

Medium

Unlikely

No

No

P2

L3

Automated Detection

Tool

Version

Checker

Description

CodeSonar
Include Page
CodeSonar_V
CodeSonar_V
(customization)Users can add a custom check for violations of this constraint.
Compass/ROSE



Can detect common violations of this rule. However, it cannot handle cases in which the value returned by fgetpos() is copied between several variables before being passed to fsetpos()

Cppcheck Premium

Include Page
Cppcheck Premium_V
Cppcheck Premium_V

premium-cert-fio44-c
Helix QAC

Include Page
Helix QAC_V
Helix QAC_V

DF4841, DF4842, DF4843


Klocwork

Include Page
Klocwork_V
Klocwork_V

CERT.FSETPOS.VALUE


LDRA tool suite
Include Page
LDRA_V
LDRA_V

82 D

Fully implemented

Parasoft C/C++test

Include Page
Parasoft_V
Parasoft_V

CERT_C-FIO44-aOnly use values for fsetpos() that are returned from fgetpos()
Polyspace Bug Finder

Include Page
Polyspace Bug Finder_V
Polyspace Bug Finder_V

CERT C: Rule FIO44-CChecks for invalid file position (rule partially covered)
PVS-Studio

Include Page
PVS-Studio_V
PVS-Studio_V

V1035

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

Key here (explains table format and definitions)

Taxonomy

Taxonomy item

Relationship

ISO/IEC TS 17961:2013Using a value for fsetpos other than a value returned from fgetpos [xfilepos]Prior to 2018-01-12: CERT: Unspecified Relationship

Bibliography

[ISO/IEC 9899:2024]7.23.9.3, "The fsetpos Function"


...

Image Added Image Added Image Added