Page History

...

my $source;
open(SOURCEmy $SOURCE, "<", $source);
@lines = (<SOURCE><$SOURCE>);
close(SOURCE$SOURCE);

It makes sure the variable containing the file name is properly defined, but it does nothing else to catch errors. Consequently, any error, such as the file not existing, being unreadable, or containing too much data to read into memory, will cause the program to abort.

...

my $source;
open(SOURCEmy $SOURCE, "<", $source) or croak "error opening $source: $!";
@lines = (<SOURCE><$SOURCE>);
close(SOURCE$SOURCE) or croak "error closing $source: $!";

...

use autodie;

my $source;
open(SOURCEmy $SOURCE, "<", $source);
@lines = (<SOURCE><$SOURCE>);
close(SOURCE$SOURCE);

EXP32:EX2: Functions that send data to standard output or standard error need not have their return values checked. This includes print and printf, but only if their file handle argument is not supplied or is explicitly set to *STDOUT or *STDERR. If they send their output to any other file handle, their return value must be checked.

...

Failure to handle error codes or other values returned by functions can lead to incorrect program flow and violations of data integrity.

Automated Detection

Related Guidelines

Bibliography

Image Modified Image Modified Image Modified