| Content by Label | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
| Info |
|---|
Information for Editors |
Risk Assessment Summary
Rule | Severity | Likelihood | Detectable | Repairable | Priority | Level |
|---|---|---|---|---|---|---|
| INT30-C | High | Likely | No | No | P9 | L2 |
| INT31-C | High | Probable | No | Yes | P12 | L1 |
| INT32-C | High | Likely | No | Yes | P18 | L1 |
| INT33-C | Low | Likely | No | Yes | P6 | L2 |
| INT34-C | Low | Unlikely | No | Yes | P2 | L3 |
| INT35-C | Low | Unlikely | No | No | P1 | L3 |
| INT36-C | Low | Probable | Yes | No | P4 | L3 |
Related Rules and Recommendations
| Navigation Map | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
...
The runtime behavior of integers in C is not always well-understood by programmers, leading to exploitable vulnerabilities. For example, assume the following code is compiled and executed on IA-32:
| Code Block |
|---|
signed char sc = SCHAR_MAX;
unsigned char uc = UCHAR_MAX;
signed long long sll = sc + uc;
|
Both the signed char sc and the unsigned char uc are subject to integer promotions in this example. Because all values of the original types can be represented as int, both values are automatically converted to int as part of the integer promotions. Further conversions are possible, if the types of these variables are not equivalent as a result of the "usual arithmetic conversions". The actual addition operation in this case takes place between the two 32-bit int values. This operation is not influenced by the resulting value is stored in a signed long long integer. The 32-bit value resulting from the addition is simply sign-extended to 64-bits after the addition operation has concluded.
Assuming that the precision of signed char is 7 bits, and the precision of unsigned char is 8 bits, this operation is perfectly safe. However, if the compiler represents the signed char and unsigned char types using 31 and 32 bit precision (respectively), the variable uc would need be converted to unsigned int instead of signed int. As a result of the usual arithmetic conversions, the signed int is converted to unsigned and the addition takes place between the two unsigned int values. Also, because uc is equal to UCHAR_MAX which is equal to UINT_MAX in this example, the addition will result in an overflow. The resulting value is then zero-extended to fit into the 64-bit storage allocated by sll.
Recommendations
Use size_t for all integer values representing the size of an object
Rules
Provide adequate range checking
All Integer operations must be guaranteed not to result in overflow, truncation, or sign error
Do not make assumptions about the type of a bit-field when used in an expression
Guarantee that integer conversions do not result in lost or misinterpreted data
Guarantee that integer operations do not result in an overflow