If a relation exists between constants, you should encode the relationship in the definitions. Do not give two independent definitions as , because a maintainer may fail to preserve that relationship when modifying the code. As a corollary, do not encode an impermanent or false relationship between constants, as because future modifications may result in an incorrect definition for the dependent constant.
...
This compliant solution does not assume a relationship when where none exists:
| Code Block | ||||
|---|---|---|---|---|
| ||||
enum { ADULT_AGE=18 };
enum { ALCOHOL_AGE=21 };
|
Risk Assessment
Failing to properly encode relationships in constant definitions may lead to the introduction of defects during maintenance. These defects could potentially result in vulnerabilities, for example, if the affected constants were used for allocating or accessing memory.
Recommendation | Severity | Likelihood |
|---|
Detectable | Repairable | Priority | Level |
|---|---|---|---|
DCL08-C | Low | Unlikely |
No | No | P1 | L3 |
Automated Detection
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
| SEI CERT C++ |
| Coding Standard | VOID DCL08-CPP. Properly encode relationships in constant definitions |
Bibliography
| [Plum 1985] | Rule 1-4 |
...
...