Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Delete two stray semicolons from code examples

...

Code Block
bgColor#FFcccc
langcpp
// s.h
struct S {
  char c;
  int a;
};
 
void init_s(S &s);
 
// s.cpp
#include "s.h"
 
void init_s(S &s); {
  s.c = 'a';
  s.a = 12;
}
 
// a.cpp
#pragma pack(push, 1)
#include "s.h"
#pragma pack(pop)
 
void f() {
  S s;
  init_s(s);
}

...

Code Block
bgColor#ccccff
langcpp
// s.h
struct S {
  char c;
  int a;
};
 
void init_s(S &s);
 
// s.cpp
#include "s.h"
 
void init_s(S &s); {
  s.c = 'a';
  s.a = 12;
}
 
// a.cpp
#include "s.h"
 
void f() {
  S s;
  init_s(s);
}

...

Violating the ODR causes undefined behavior, which can result in exploits as well as denial-of-service attacks. As shown in "Support for Whole-Program Analysis and the Verification of the One-Definition Rule in C++" [Quinlan 06], failing to enforce the ODR enables a virtual function pointer attack known as the VPTR exploit. In this exploit, an object's virtual function table is corrupted so that calling a virtual function on the object results in malicious code being executed. See the paper by Quinlan and colleagues for more details. However, note that to introduce the malicious class, the attacker must have access to the system building the code.

Rule

Severity

Likelihood

Detectable

Remediation CostRepairable

Priority

Level

DCL60-CPP

High

Unlikely

Yes

NoHigh

P3P6

L3L2

Automated Detection

Tool

Version

Checker

Description

Astrée

Include Page
Astrée_V
Astrée_V

type-compatibility
definition-duplicate
undefined-extern
undefined-extern-pure-virtual
external-file-spreading
type-file-spreading
Partially checked
Axivion Bauhaus Suite

Include Page
Axivion Bauhaus Suite_V
Axivion Bauhaus Suite_V

CertC++-DCL60
CodeSonar
Include Page
CodeSonar_V
CodeSonar_V

LANG.STRUCT.DEF.FDH
LANG.STRUCT.DEF.ODH

Function defined in header file
Object defined in header file
Helix QAC

Include Page
Helix QAC_V
Helix QAC_V

C++1067, C++1509, C++1510


LDRA tool suite
Include Page
LDRA_V
LDRA_V

286 S, 287 S

Fully implemented

Parasoft C/C++test

Include Page
Parasoft_V
Parasoft_V

CERT_CPP-DCL60-a

A class, union or enum name (including qualification, if any) shall be a unique identifierThe One Definition Rule shall not be violated

Polyspace Bug Finder

Include Page
Polyspace Bug Finder_V
Polyspace Bug Finder_V

CERT C++: DCL60-CPPChecks for inline constraints not respected (rule partially covered)
RuleChecker
Include Page
RuleChecker_V
RuleChecker_V
type-compatibility
definition-duplicate
undefined-extern
undefined-extern-pure-virtual
external-file-spreading
type-file-spreading
Partially checked

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

...