Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

C programmers commonly make errors regarding the precedence rules of C operators because of the unintuitive low-precedence levels of &, |, ^, <<, and >>. Mistakes regarding precedence rules can be avoided by the suitable use of parentheses. Using parentheses defensively reduces errors and, if not taken to excess, makes the code more readable.

Subclause 6.5 of the C Standard defines the precedence of operation by the order of the subclauses.

Noncompliant Code Example

The intent of the expression in this noncompliant code example is to test the least significant bit of x:

Code Block
bgColor#FFCCCC
langc
x & 1 == 0

Because of operator precedence rules, the expression is parsed as

Code Block
bgColor#FFCCCC
langc
x & (1 == 0)

which evaluates to

Code Block
bgColor#FFCCCC
langc
(x & 0)

and then to 0.

Compliant Solution

In this compliant solution, parentheses are used to ensure the expression evaluates as expected:

Code Block
bgColor#ccccff
langc
(x & 1) == 0

Exceptions

EXP00-C-EX1: Mathematical expressions that follow algebraic order do not require parentheses. For instance, in the expression

Code Block
x + y * z

the multiplication is performed before the addition by mathematical convention. Consequently, parentheses to enforce the algebraic order would be redundant:

Code Block
bgColor#ffcccc
langc
x + (y * z)

Risk Assessment

Mistakes regarding precedence rules may cause an expression to be evaluated in an unintended way, which can lead to unexpected and abnormal program behavior.

Recommendation

Severity

Likelihood

Remediation Cost

Priority

Level

EXP00-C

Low

Probable

Medium

P4

L3

Automated Detection

Tool

Version

Checker

Description

CodeSonar
Include Page
CodeSonar_V
CodeSonar_V

LANG.STRUCT.PARENS

Missing Parentheses

ECLAIR

Include Page
ECLAIR_V
ECLAIR_V

CC2.EXP00

Fully implemented

Klocwork
Include Page
Klocwork_V
Klocwork_V
MISRA.EXPR.PARENS.2012
LDRA tool suite
Include Page
LDRA_V
LDRA_V

361 S, 49 S

Fully implemented

Parasoft C/C++test
Include Page
Parasoft_V
Parasoft_V
CODSTA-97Fully implemented
Polyspace Bug FinderR2016aPossibly unintended evaluation of expression because of operator precedence rules

Operator precedence rules cause unexpected evaluation order in arithmetic expression

PRQA QA-C
Include Page
PRQA QA-C_v
PRQA QA-C_v

3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400

Fully implemented
PVS-Studio

Include Page
PVS-Studio_V
PVS-Studio_V

V502, V593, V634, V648
SonarQube C/C++ Plugin
Include Page
SonarQube C/C++ Plugin_V
SonarQube C/C++ Plugin_V
S864

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

Bibliography

[Dowd 2006]Chapter 6, "C Language Issues" ("Precedence," pp. 287–288)
[Kernighan 1988]
[NASA-GB-1740.13]Section 6.4.3, "C Language"