Integer types in C have both a size and a precision. The size indicates the number of bytes used by an object and can be retrieved for any object or type using the
sizeof operator. The precision of an integer type is the number of bits it uses to represent values, excluding any sign and padding bits.
Padding bits contribute to the integer's size, but not to its precision. Consequently, inferring the precision of an integer type from its size may result in too large a value, which can then lead to incorrect assumptions about the numeric range of these types. Programmers should use correct integer precisions in their code, and in particular, should not use the
sizeof operator to compute the precision of an integer type on architectures that use padding bits or in strictly conforming (that is, portable) programs.
Noncompliant Code Example
This noncompliant code example illustrates a function that produces 2 raised to the power of the function argument. To prevent undefined behavior in compliance with INT34-C. Do not shift an expression by a negative number of bits or by greater than or equal to the number of bits that exist in the operand, the function ensures that the argument is less than the number of bits used to store a value of type
However, if this code runs on a platform where
unsigned int has one or more padding bits, it can still result in values for
exp that are too large. For example, on a platform that stores
unsigned int in 64 bits, but uses only 48 bits to represent the value, a left shift of 56 bits would result in undefined behavior.
This compliant solution uses a
popcount() function, which counts the number of bits set on any unsigned integer, allowing this code to determine the precision of any integer type, signed or unsigned.
Implementations can replace the
PRECISION() macro with a type-generic macro that returns an integer constant expression that is the precision of the specified type for that implementation. This return value can then be used anywhere an integer constant expression can be used, such as in a static assertion. (See DCL03-C. Use a static assertion to test the value of a constant expression.) The following type generic macro, for example, might be used for a specific implementation targeting the IA-32 architecture:
The revised version of the
pow2() function uses the
PRECISION() macro to determine the precision of the unsigned type:
Some platforms, such as the Cray Linux Environment (CLE; supported on Cray XT CNL compute nodes), provide
a _popcnt instruction that can substitute for the
Mistaking an integer's size for its precision can permit invalid precision arguments to operations such as bitwise shifts, resulting in undefined behavior.
|Supported: Astrée reports overflows due to insufficient precision.|
Use correct integer precisions when checking the right hand operand of the shift operator
|Polyspace Bug Finder|
|CERT C: Rule INT35-C||Checks for situations when integer precisions are exceeded (rule fully covered)|
Key here (explains table format and definitions)
|CWE 2.11||CWE-681, Incorrect Conversion between Numeric Types|
CERT-CWE Mapping Notes
Key here for mapping notes
CWE-190 and INT35-C
Intersection( INT35-C, CWE-190) = Ø
INT35-C used to map to CWE-190 but has been replaced with a new rule that has no overlap with CWE-190.
CWE-681 and INT35-C
Intersection(INT35-C, CWE-681) = due to incorrect use of integer precision, conversion from one data type to another causing data to be omitted or translated in a way that produces unexpected values
CWE-681 - INT35-C = list2, where list2 =
- conversion from one data type to another causing data to be omitted or translated in a way that produces unexpected values, not involving incorrect use of integer precision
INT35-C - CWE-681 = list1, where list1 =
- incorrect use of integer precision not related to conversion from one data type to another