Do not hard code the size of a type into an application. Because of alignment, padding, and differences in basic types (e.g., 32-bit versus 64-bit pointers), the size of most types can vary between compilers and even versions of the same compiler. Using the
sizeof operator to determine sizes improves the clarity of what is meant and ensures that changes between compilers or versions will not affect the code.
Type alignment requirements can also affect the size of structures. For example, the size of the following structure is implementation-defined:
Assuming 32-bit integers and 64-bit doubles, for example, the size can range from 12 to 16 bytes, depending on alignment rules.
Noncompliant Code Example
This noncompliant code example attempts to declare a two-dimensional array of integers with variable length rows. On a platform with 64-bit integers, the loop will access memory outside the allocated memory section.
This compliant solution replaces the hard-coded value
Also see MEM02-C. Immediately cast the result of a memory allocation function call into a pointer to the allocated type for a discussion on the use of the
sizeof operator with memory allocation functions.
EXP09-C-EX1: The C Standard explicitly declares
sizeof(char) == 1, so any sizes based on characters or character arrays may be evaluated without using
sizeof. This does not apply to
char* or any other data types.
Porting code with hard-coded sizes can result in a buffer overflow or related vulnerability.
Can detect violations of this recommendation. In particular, it looks for the size argument of
|CC2.EXP09||Can detect violations of this recommendation. In particular, it considers when the size of a type is used by |
|LDRA tool suite|
|Hard-coded object size used to manipulate memory||Memory manipulation with hard-coded size instead of sizeof|
|SEI CERT C++ Coding Standard||VOID EXP09-CPP. Use sizeof to determine the size of a type or variable|
|MITRE CWE||CWE-805, Buffer access with incorrect length value|