switch statement can be mixed with a block of code by starting the block in one case label, then having another case label within the block. The block can be pictured as spanning more than one case statement.
Subclause 184.108.40.206, paragraph 2, of the C Standard [ISO/IEC 9899:2011] says,
If a switch statement has an associated case or default label within the scope of an identifier with a variably modified type, the entire switch statement shall be within the scope of that identifier.154
Footnote 154 says:
That is, the declaration either precedes the switch statement, or it follows the last case or default label associated with the switch that is in the block containing the declaration.
Note that the standard does not disallow jumping via
switch into loops that do not involve variably modified type identifiers. Consequently, loops and other blocks can be freely intermixed with
switch statements. Unfortunately, such intermixing creates code that is, at best, confusing and unclear in what it does, which can cause undesirable behavior.
The examples here fall under the exception MSC17-C-EX2 in MSC17-C. Finish every set of statements associated with a case label with a break statement.
Noncompliant Code Example
This example shows the use of the
switch statement to jump into a
i = 1, the entire
for loop is executed. When
i = 2, two increments to
j are made before the loop starts. When
i = 3, one increment to
j is made before the loop starts. The default case is no loop. Consequently, the function has the following behavior:
The compliant solution separates the
Noncompliant Code Example (Duff's Device)
Duff's device is a curious optimization applied to code intended to perform a serial copy. That is, it copies a series of bytes into one memory output in turn. A simple code to do this would be as follows:
However, this code might be unacceptably slow because the
while condition is performed
count times. The classic code for Duff's device unrolls this loop to minimize the number of comparisons performed:
In this code, the first iteration of the loop is subject to the
switch statement, so it performs
count % 8 assignments. Each subsequent iteration of the loop performs 8 assignments. (Being outside the loop, the
switch statement is ignored.) Consequently, this code performs
count assignments, but only
n comparisons, so it is usually faster.
The code is widely considered to be valid C and C++ and is supported by all compliant compilers. When describing Duff's device, the creator [Duff 1988] noted,
Many people . . . have said that the worst feature of C is that switches don't break automatically before each case label. This code forms some sort of argument in that debate, but I'm not sure whether it's for or against.
Compliant Solution (Duff's Device)
This is an alternative implementation of Duff's device, which separates the
switch statement and loop:
|LDRA tool suite|
|245 S||Fully implemented|
|Polyspace Bug Finder|
|CERT C: Rec. MSC20-C||Checks for situations where switch label is not at the outermost level of switch statement body (rec. fully covered)|
|SonarQube C/C++ Plugin|
|SEI CERT C++ Coding Standard||VOID MSC20-CPP. Do not use a switch statement to transfer control into a complex block|
|ISO/IEC TR 24731-1:2007|
|MISRA C:2012||Rule 16.2 (required)|