Evaluation of an expression may produce side effects. At specific points during execution, known as sequence points, all side effects of previous evaluations are complete, and no side effects of subsequent evaluations have yet taken place. Do not depend on the order of evaluation for side effects unless there is an intervening sequence point.
The C Standard, 6.5, paragraph 2 [ISO/IEC 9899:2011], states
If a side effect on a scalar object is unsequenced relative to either a different side effect on the same scalar object or a value computation using the value of the same scalar object, the behavior is undefined. If there are multiple allowable orderings of the subexpressions of an expression, the behavior is undefined if such an unsequenced side effect occurs in any of the orderings.
The following sequence points are defined in the C Standard, Annex C [ISO/IEC 9899:2011]:
- Between the evaluations of the function designator and actual arguments in a function call and the actual call
- Between the evaluations of the first and second operands of the following operators:
- Logical AND:
- Logical OR:
- Logical AND:
- Between the evaluations of the first operand of the conditional
?:operator and whichever of the second and third operands is evaluated
- The end of a full declarator
- Between the evaluation of a full expression and the next full expression to be evaluated; the following are full expressions:
- An initializer that is not part of a compound literal
- The expression in an expression statement
- The controlling expression of a selection statement (
- The controlling expression of a
- Each of the (optional) expressions of a
- The (optional) expression in a
- Immediately before a library function returns
- After the actions associated with each formatted input/output function conversion specifier
- Immediately before and immediately after each call to a comparison function, and also between any call to a comparison function and any movement of the objects passed as arguments to that call
This rule means that statements such as
have defined behavior, and statements such as the following do not:
Not all instances of a comma in C code denote a usage of the comma operator. For example, the comma between arguments in a function call is not a sequence point. However, according to the C Standard, 18.104.22.168, paragraph 10 [ISO/IEC 9899:2011]
Every evaluation in the calling function (including other function calls) that is not otherwise specifically sequenced before or after the execution of the body of the called function is indeterminately sequenced with respect to the execution of the called function.
This rule means that the order of evaluation for function call arguments is unspecified and can happen in any order.
Noncompliant Code Example
Programs cannot safely rely on the order of evaluation of operands between sequence points. In this noncompliant code example,
i is evaluated twice without an intervening sequence point, so the behavior of the expression is undefined:
These examples are independent of the order of evaluation of the operands and can be interpreted in only one way:
Noncompliant Code Example
The call to
func() in this noncompliant code example has undefined behavior because there is no sequence point between the argument expressions:
The first (left) argument expression reads the value of
i (to determine the value to be stored) and then modifies
i. The second (right) argument expression reads the value of
i between the same pair of sequence points as the first argument, but not to determine the value to be stored in
i. This additional attempt to read the value of
i has undefined behavior.
This compliant solution is appropriate when the programmer intends for both arguments to
func() to be equivalent:
This compliant solution is appropriate when the programmer intends for the second argument to be 1 greater than the first:
Noncompliant Code Example
It is unspecified what order
b() are called in; the only guarantee is that both
b() will be called before
c() is called. If
b() rely on shared state when calculating their return value, as they do in this example, the resulting arguments passed to
c() may differ between compilers or architectures.
In this compliant solution, the order of evaluation for
b() is fixed, and so no unspecified behavior occurs:
Attempting to modify an object multiple times between sequence points may cause that object to take on an unexpected value, which can lead to unexpected program behavior.
|Detects simple violations of this rule, but does not diagnose unsequenced function call arguments.|
Can detect simple violations of this rule. It needs to examine each expression and make sure that no variable is modified twice in the expression. It also must check that no variable is modified once, then read elsewhere, with the single exception that a variable may appear on both the left and right of an assignment operator
Can detect the specific instance where a statement contains multiple side effects on the same value with an undefined evaluation order because, with different compiler flags or different compilers or platforms, the statement may behave differently
Can detect violations of this rule when the
|LDRA tool suite|
35 D, 1 Q, 9 S, 30 S, 134 S
The value of an expression shall be the same under any order of evaluation that the standard permits
|Polyspace Bug Finder|
|MISRA C:2012 Rule 13.2|
The value of an expression and its persistent side effects shall be the same under all permitted evaluation orders
|SonarQube C/C++ Plugin|
Key here (explains table format and definitions)
|CERT C||EXP50-CPP. Do not depend on the order of evaluation for side effects||Prior to 2018-01-12: CERT: Unspecified Relationship|
|CERT Oracle Secure Coding Standard for Java||EXP05-J. Do not follow a write by a subsequent write or read of the same object within an expression||Prior to 2018-01-12: CERT: Unspecified Relationship|
|ISO/IEC TR 24772:2013||Operator Precedence/Order of Evaluation [JCW]||Prior to 2018-01-12: CERT: Unspecified Relationship|
|ISO/IEC TR 24772:2013||Side-effects and Order of Evaluation [SAM]||Prior to 2018-01-12: CERT: Unspecified Relationship|
|MISRA C:2012||Rule 12.1 (advisory)||Prior to 2018-01-12: CERT: Unspecified Relationship|
|CWE 2.11||CWE-758||2017-07-07: CERT: Rule subset of CWE|
CERT-CWE Mapping Notes
Key here for mapping notes
CWE-758 and EXP30-C
Independent( INT34-C, INT36-C, MEM30-C, MSC37-C, FLP32-C, EXP33-C, EXP30-C, ERR34-C, ARR32-C)
CWE-758 = Union( EXP30-C, list) where list =
- Undefined behavior that results from anything other than reading and writing to a variable twice without an intervening sequence point.
|[ISO/IEC 9899:2011]||6.5, "Expressions"|
22.214.171.124, "Function Calls"
Annex C, "Sequence Points"
|[Summit 2005]||Questions 3.1, 3.2, 3.3, 3.3b, 3.7, 3.8, 3.9, 3.10a, 3.10b, and 3.11|