Many functions have the option of returning a pointer to an object or returning
NULL if a valid pointer cannot be produced. Some functions return arrays, which appear like a pointer to an object. However, if a function has the option of returning an array or indicating that a valid array is not possible, it should not return
NULL. Instead, the function should return an empty array. Often, code that calls a function that returns an array intends merely to iterate over the array elements. In this case, the calling code need not change—iterating over the elements works correctly even if the returned array is empty, so the calling code need not check the return value for
This situation is complicated by the fact that C does not keep track of the length of an array. However, two popular methods have emerged to emulate this behavior. The first is to wrap the array in a struct with an integer storing the length. The second is to place a sentinel value at the end of the data in the array. This second approach is most commonly manifested in null-terminated byte strings (NTBSs).
Noncompliant Code Example (Struct)
In this noncompliant code example, an inventory system keeps track of the total number of different items (denoted
length). Each item is given an index in the array, and the value for that index is the stock of that item. Adding a new item increases
length in the struct. Stocking more of an item increases the value for that item's index. For example, if 5 books and 2 erasers are in stock, the inventory would be
stockOfItem = 5 and
stockOfItem = 2, assuming books are index 0 and erasers are index 1.
The problem arises in this setup when no items are being stocked.
getStock would recognize that
length = 0 and would return
NULL. In this noncompliant code example, erroneous behavior results from
main neglects to check for such a value. It results in an abnormal program termination after returning to the
This compliant solution eliminates the
NULL return and returns the
item array, even if it is zero-length. The main function can effectively handle this situation without exhibiting erroneous behavior. Since the array lives on the stack, it must prevent returning a value in the stack frame (as mandated by DCL30-C. Declare objects with appropriate storage durations). So the getStack() function also takes a pointer to
Inventory, so that it can return a pointer to its contents safely.
Noncompliant Code Example (Sentinel Value)
This noncompliant code example implements an inventory system similar to the one described previously. However, instead of storing the length of the array in a struct, a sentinel value of
FINAL_ITEM is used. The value for the index following the last item is set as
FINAL_ITEM. It is assumed that out-of-stock items (assigned value 0) are removed from the array, and the contents of later items are shifted to lower indexes.
The following code attempts to return an array of the items in stock, sorted by the amount of each item in stock. The
arraySort function incorrectly returns
NULL instead of a pointer to an empty array when no items are in stock. The null return is improperly handled by the
main function, which is attempting to print out the returned array, and an abnormal program termination results.
Compliant Solution (Sentinel Value)
This compliant solution correctly returns an empty array in the
sortedArray function. If the size of the array is 0, then
sortedArray allocates an array of size 1 and fills it with the sentinel value. It can then successfully return that array to the caller function.
NULL rather than a zero-length array can lead to vulnerabilities when the client code does not handle
NULL properly. Abnormal program termination can result when the calling function performs operations on
Avoid accessing arrays out of bounds
413, 418, 419, 420, 473,
|[Bloch 2008]||Item 43, "Return Empty Arrays or Collections, Not Nulls"|